Skip to content

Conversation

@petk
Copy link
Member

@petk petk commented Nov 2, 2025

These then also need to be synced.

Follow up of #20355

@petk petk force-pushed the patch-ext-zip-GH-20355 branch from fc0796b to 5a12022 Compare November 2, 2025 18:13
@petk petk changed the title GH-20355: Sync remaining parts of ext/zip for libzip >= 1.0.0 ext/zip: Sync remaining parts for libzip >= 1.0.0 Nov 2, 2025
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I only did the same change in zip_stream.c in a newer PR, will wait your merge.

@petk
Copy link
Member Author

petk commented Nov 2, 2025

I see. There is another PR here... Ok, then if it's ok with you merging this and if you can rebase than yours :)

@petk petk merged commit 8d1a42f into php:master Nov 2, 2025
10 checks passed
@petk petk deleted the patch-ext-zip-GH-20355 branch November 2, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants